Re: [Qemu-devel] [PATCH] report read/write errors to IDE guest driver as ECC errors

[Ian Jackson]

Daniel P. Berrange writes ("Re: [Qemu-devel] [PATCH] report read/write errors 
to IDE guest driver as ECC errors"):
> Unless someone wants to implement the ENOSPC handling right now, I'd 
> like to see this patch just committed as is, so we at least get
> incremental benefit over current behaviour, which definitely *does*
> corrupt guest filesystems by silently pretending the write succeeed.

Absolutely.

> Special ENOSPC handling can be added on top.
> I agree that pausing the guest is probably best option in that scenario,

I disagree.  Most reasonable guests will have special handling for
write failures on their disks.  For example, Linux will (in the
default setup) remount the fs readonly precisely to prevent
corruption.

Pausing the guest denies the guest the ability to take whatever action
it really wants to.

Ian.