[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/3] [x86] Add Core 2 Duo CPU specification

From: Alexander Graf
Subject: Re: [Qemu-devel] [PATCH 0/3] [x86] Add Core 2 Duo CPU specification
Date: Mon, 18 Aug 2008 16:43:52 +0200

On Aug 18, 2008, at 4:31 PM, Anthony Liguori wrote:

Alexander Graf wrote:

this set of patches attempts to implement a CPU definition set for current Intel CPUs that resembles an original as closely as currently possible. Several features a current Intel CPU has are not implemented by qemu, but that should not keep us from adding this definition so people can add features later on.

As a side effect, I made the sysenter instruction 64-bit aware. This was an issue in KVM, that used the 32-bit cpu struct variables to hold 64-bit MSR values sysenter needs. I believe it to be a step in the right direction to not fix this only for KVM, but make the functionality available to qemu as well.

Does anyone have any objections to this series? I see no obvious flaws and it looks to be quite self contained. My understanding is that this is needed to enable OS X guest support so it seems worthwhile to apply to me.

It's missing save/restore support. I'll post an updated series later today.



Anthony Liguori


reply via email to

[Prev in Thread] Current Thread [Next in Thread]