|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] Re: [5055] Handle terminating signals (Gerd Hoffmann) |
Date: | Fri, 22 Aug 2008 08:50:27 -0500 |
User-agent: | Thunderbird 2.0.0.16 (X11/20080723) |
Jan Kiszka wrote:
Anthony Liguori wrote:I do check for warnings. The version of GCC I'm using (3.4.6 20060404 (Red Hat 3.4.6-9)) does not complain about these things. We probably should add -Wall to the build and take the time to fix up all of the warnings that occur.Makes /me wonder why 3.4 thinks there is no problem here (while this is obviously wrong). Being lazy and SuSE-based (which only provides a 3.3.3 for such legacy use cases, IIRC), and also remembering vaguely that there used to be warnings about 3.4 /wrt qemu, I kept 3.3.3.
Could just be that more warnings are enabled by default with your particular version of GCC.
BTW, do you also check for 64-bit issues? My feeling is that this - at least - used to be a rare host platform for qemu contributors.
I run a 64-bit host.I run Fedora 9 x86_64. I have as many optional libraries installed as possible. I also have a mingw32 cross compiler setup that I use to test the windows build. The mingw32 compiler is gcc4 and throws an awful lot of warnings.
Regards, Anthony Liguori
Jan
[Prev in Thread] | Current Thread | [Next in Thread] |