[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH 0/5] [sh4] patches for SH4 system emulation

From: Aurelien Jarno
Subject: Re: [Qemu-devel] Re: [PATCH 0/5] [sh4] patches for SH4 system emulation
Date: Fri, 22 Aug 2008 23:30:35 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

On Sat, Aug 23, 2008 at 04:54:50AM +0900, Shin-ichiro KAWASAKI wrote:
> Jan Kiszka wrote:
>>> I hope these patches will help and merged in trunk.
>>> Any comments will be welcome.
>> I cannot comment on your patches, but maybe you can comment on (or test)
>> the tas.b issue of qemu's sh4 emulation
>> http://comments.gmane.org/gmane.comp.emulators.qemu/27235
>> specifically the last proposed solution
>> http://permalink.gmane.org/gmane.comp.emulators.qemu/27337
> Andrzej's two patches are both seem to be consistent with tas.b
> specification.
> To make it sure, I've taken out a function, __pthread_spin_trylock(),  
> from glibc's linuxthreads/sysdeps/sh/pspinlock.c, as the test code for
> tas.b.  I confirmed that current QEMU implementation fails
> this test, and whichever of the two patches makes it pass the test. 
> In my opinion, the first patch is the better, because it is smaller and
> easier to understand.  I add the patch to the end of this mail again,
> which is modified to avoid patch failure.
> FYI, I add the test code, too.

Thanks, applied.

  .''`.  Aurelien Jarno             | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   address@hidden         | address@hidden
   `-    people.debian.org/~aurel32 | www.aurel32.net

reply via email to

[Prev in Thread] Current Thread [Next in Thread]