[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] MIPS: Fix dmtc0 instruction
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH] MIPS: Fix dmtc0 instruction |
Date: |
Sat, 23 Aug 2008 19:24:04 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Sat, Aug 23, 2008 at 06:42:34PM +0200, Hervé Poussineau wrote:
> Hi,
>
> In gen_dmtc0 function, TCG temporary variable t0 is freed at the end of
> the function. Variable is freed again in the gen_dmtc0 caller.
> I removed the free in gen_dmtc0, to do like in gen_dmfc0, gen_mfc0,
> gen_mtc0.
>
> Incidentally, this unregresses NetBSD on Pica 61.
This was also affecting Linux MIPS64 and I have noticed the problem this
morning (though it seems to be a few weeks old).
I have applied the patch, and also removed another tcg_temp_free(t0)
which has been left. Thanks!
> Hervé
> Index: target-mips/translate.c
> ===================================================================
> --- target-mips/translate.c (revision 5074)
> +++ target-mips/translate.c (working copy)
> @@ -5188,7 +5188,6 @@
> rn, reg, sel);
> }
> #endif
> - tcg_temp_free(t0);
> /* For simplicity assume that all writes can cause interrupts. */
> if (use_icount) {
> gen_io_end();
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' address@hidden | address@hidden
`- people.debian.org/~aurel32 | www.aurel32.net