Re: [Qemu-devel] [PATCH 0/6] Add UUID command-line option

[Blue Swirl]

On 8/24/08, Gleb Natapov <address@hidden> wrote:
> Hello,
>
>   This is one more try to push this patch series into qemu. This time
>  I don't use vmport interface. Instead I implemented simple communication
>  channel between  qemu and BIOS using IO port.  I decided not to  use
>  firmware interface since current users of the interface may depend on
>  exact structure layout, so it doesn't look like a good idea to add
>  arbitrary fields there. Also I don't want to copy the whole ROM into BIOS
>  just to access one field of it. IO channel is implemented by the first
>  patch of the series. Patches 2-5 implement UUID related stuff. Patch 6
>  passes host CPU frequency to fill in SM BIOS table.
>
>  Please comment.

I disagree about not using the firmware interface. The structure can
be extended and even new versions defined, all structure users are
open source. UUID is not architecture specific, so it should use the
main structure instead if the architecture specific substructure
(nvram_arch*). Adding UUID to unused fields will not break anything.