Re: [Qemu-devel] [5083] PPC: Switch a few instructions to TCG

[Aurelien Jarno]

On Mon, Aug 25, 2008 at 12:08:17AM +0200, J. Mayer wrote:
> On Sun, 2008-08-24 at 19:05 +0000, Aurelien Jarno wrote:
> > Revision: 5083
> >           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5083
> > Author:   aurel32
> > Date:     2008-08-24 19:05:35 +0000 (Sun, 24 Aug 2008)
> > 
> > Log Message:
> > -----------
> > PPC: Switch a few instructions to TCG
> 
> It seems like you forgot to consider that I might be working on this
> subject, as I announced here last month and care if you break my work in
> any way.
> Then, you also "forgot" to wait for the fixes needed to address
> regression that have been introduced by previous inconsidered commits in
> PowerPC emulation: I also said that this was the _first thing_ to be
> done before anything else in PowePC code. 
> Then, I can be sure that you "forgot" to test if your patch breaks any
> PowerPC targets, as some do not run now...
> Last but not least, you also "forgot" to submit your patch, wait for
> comments, reviews, tests...
> 
> All this is unacceptable; furthermore, just giving a quick look, there
> seem to be many things that should never have been commited as-is and
> have to be fixed before this set of could eventually be merged.
> 
> Please revert_ now_.

Sorry, I have probably missed your email, reverted.

-- 
  .''`.  Aurelien Jarno             | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   address@hidden         | address@hidden
   `-    people.debian.org/~aurel32 | www.aurel32.net