qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] xenner: add event channel implementation.


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 1/2] xenner: add event channel implementation.
Date: Mon, 25 Aug 2008 14:58:33 +0200
User-agent: Thunderbird 2.0.0.16 (X11/20080723)

  Hi,

>>>  XEN_OBJS += xen_console.o xen_framebuffer.o xen_disk.o xen_nic.o
>>> +XEN_OBJS += xenner_libxc_evtchn.o
>> Historically, we didn't have directories in QEMU because we used CVS and
>> directories are a nightmare.  With the shear number of files being added
>> for Xen, it probably makes sense to stick them all in a directory.
> 
> Hmm, the xen guys vetoed file renames, so I don't feel like sticking
> stuff used by xen somewhere else.  For the emulation bits aka
> xenner*.[ch] it should be no problem though.  New xenner/ toplevel
> directory?

Comments on this one?

Another idea:  Do the initial merge in hw/, and later on, after the
qemu-xen tree catched up, move all xen (and xen emulation) bits to
another directory.  That would keep the scm revision history intact for
the Xen guys.

I also think we need to organize the source -- especially the header
files -- a bit better if we start to separate the code into more
subdirectories.  And I'd prefer to have some agreement on how the source
tree should look like before starting to shuffle around files, so I have
to do it only once ...

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]