[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH]: fix a nit in exec.c
From: |
Laurent Desnogues |
Subject: |
Re: [Qemu-devel] [PATCH]: fix a nit in exec.c |
Date: |
Fri, 29 Aug 2008 13:27:03 +0200 |
On Fri, Aug 22, 2008 at 3:56 PM, Tristan Gingold <address@hidden> wrote:
> Hi,
>
> the parameter of page_find_alloc is a page index and not an address.
>
> Tristan.
>
> Signed-off-by: Tristan Gingold <address@hidden>
>
> --- exec.c (revision 5062)
> +++ exec.c (working copy)
> @@ -286,7 +286,7 @@
> #if TARGET_LONG_BITS > 32
> /* Host memory outside guest VM. For 32-bit targets we have already
> excluded high addresses. */
> - if (index > ((target_ulong)L2_SIZE * L1_SIZE * TARGET_PAGE_SIZE))
> + if (index > ((target_ulong)L2_SIZE * L1_SIZE))
> return NULL;
> #endif
> lp = &l1_map[index >> L2_BITS];
This patch is correct and fixes the problem I spotted here:
http://lists.gnu.org/archive/html/qemu-devel/2008-08/msg00241.html
Is there any hope to see this committed?
Laurent