|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [REPOST] [PATCH 0/2] IDE error checking |
Date: | Sat, 06 Sep 2008 22:00:27 -0500 |
User-agent: | Thunderbird 2.0.0.16 (X11/20080723) |
Ian Jackson wrote:
In these two patches I make the IDE controller emulation pay attention to errors returned by the bdrv functions. The first of these patches was first posted in February 2008 and has been discussed extensively. There was some discussion as to whether it would be better, in cases where the error was ENOSPC, to stop the guest than to pass it an IDE error. However it must be clear that regardless of whether that would be better in some circumstances, giving the guest an IDE error is better than silently ignoring the error, throwing away the guest's data.
The proper solution is not significantly more difficult. Just add a switch(errno) { case ENOSPC: vm_stop(0); term_printf("Ran out of disk space\n"); break; }. That's all I'm asking for.
Regards, Anthony Liguori
I would therefore submit that my patch should be applied immediately. If anyone wants to implement automatic stopping of guests on ENOSPC errors this should then be done as an optional enhancement. In this patch pair I don't fix the call to bdrv_flush in FLUSH CACHE. This is because that's entangled with another dropped series of patches to implement use of aio for cache flushing and guest control of the host write cache. Ian.
[Prev in Thread] | Current Thread | [Next in Thread] |