[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [5187] Use signalfd() to work around signal/select race
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [5187] Use signalfd() to work around signal/select race |
Date: |
Wed, 10 Sep 2008 19:55:00 +0300 |
On 9/10/08, Anthony Liguori <address@hidden> wrote:
> Revision: 5187
> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5187
> Author: aliguori
> Date: 2008-09-10 15:45:19 +0000 (Wed, 10 Sep 2008)
>
> Log Message:
> -----------
> Use signalfd() to work around signal/select race
>
> This patch introduces signalfd() to work around the signal/select race in
> checking for AIO completions. For platforms that don't support signalfd(),
> we
> emulate it with threads.
>
> There was a long discussion about this approach. I don't believe there are
> any
> fundamental problems with this approach and I believe eliminating the use of
> signals is a good thing.
>
> I've tested Windows and Linux using Windows and Linux guests. I've also
> checked
> for disk IO performance regressions.
>
> Signed-off-by: Anthony Liguori <address@hidden>
>
> Modified Paths:
> --------------
> trunk/Makefile
> trunk/Makefile.target
> trunk/block-raw-posix.c
> trunk/block-raw-win32.c
> trunk/block.c
> trunk/block.h
> trunk/vl.c
The file compatfd.h is missing.