[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/2] ppc: Convert op_andi to TCG

From: Blue Swirl
Subject: Re: [Qemu-devel] [PATCH 2/2] ppc: Convert op_andi to TCG
Date: Sun, 14 Sep 2008 14:35:01 +0300

On 9/14/08, Andreas Färber <address@hidden> wrote:
> Replace op_andi_... with tcg_gen_andi_tl.

>   GEN_HANDLER2(andi_, "andi.", 0x1C, 0xFF, 0xFF, 0x00000000, PPC_INTEGER)
>   {
>      tcg_gen_mov_tl(cpu_T[0], cpu_gpr[rS(ctx->opcode)]);
>  -    gen_op_andi_T0(UIMM(ctx->opcode));
>  +    tcg_gen_andi_tl(cpu_T[0], cpu_T[0], UIMM(ctx->opcode));
>      tcg_gen_mov_tl(cpu_gpr[rA(ctx->opcode)], cpu_T[0]);
>      gen_set_Rc0(ctx);
>   }

Small comment: this would be more optimally:
cpu_gpr[rS(ctx->opcode)], UIMM(ctx->opcode));

The same applies to andis.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]