[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [5274] Add signed versions of save/load functions

From: Blue Swirl
Subject: Re: [Qemu-devel] [5274] Add signed versions of save/load functions
Date: Fri, 26 Sep 2008 00:14:36 +0300

On 9/25/08, Anthony Liguori <address@hidden> wrote:
> Blue Swirl wrote:
> > Right. I think the patch should be split into three operations: signed
> > version addition, int to size_t change and this dangerous type size
> > change. Only the first one is obviously correct, which I thought all
> > of these changes were.
> >
> > Thanks for debugging, I'll revert this patch and make new patches for
> review.
> >
> >
>  Thanks!

I split the patch into three pieces. The signed API patch should be
safe, two others need more careful review and testing.

Attachment: signed_savevm_api.diff
Description: plain/text

Attachment: use_size_t.diff
Description: plain/text

Attachment: buggy_use_more_accurate_types.diff
Description: plain/text

reply via email to

[Prev in Thread] Current Thread [Next in Thread]