[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Qemu-devel] [PATCH] USB over network

From: Gal Hammer
Subject: RE: [Qemu-devel] [PATCH] USB over network
Date: Tue, 7 Oct 2008 01:34:30 -0700

> How about USB drives or printers, do they work?

Basically, if it works locally, it should work over network. The remote feature 
should be as good as the qemu's current support for USB emulation.

> A few comments:
> - 'static' can be applied to a lot of functions

I'll search for these.

> - instead of including linux/usb_ch9.h, you should define the
> structures, like in usb-linux.c

No problem.

> - while the daemon is linux specific, the remote protocol looks like
> host OS neutral, so it should not be too tightly tied to usb-linux.c

The protocol is still in its pre-draft status.

> - name __ioctl looks like it could clash with system defines and it's
> not very descriptive

Will changed (Do you have an idea how to name it?).

> - USB_REMOTE_MAGIC is not endian neutral, or is that the purpose?

I didn't understand. Do you mean that the value might change if qemu is running 
on a different type of CPU?

> - upper-case structure names are IMHO ugly

Can't take the Windows' coding conversion from a Windows programmer :-). I'll 
lower case them.
> Otherwise, great idea!

Thanks. But I can't take the credit for it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]