Re: [Qemu-devel] [PATCH] USB over network

[Blue Swirl]

On 10/7/08, Gal Hammer <address@hidden> wrote:
> > How about USB drives or printers, do they work?
>
>
> Basically, if it works locally, it should work over network. The remote 
> feature should be as good as the qemu's current support for USB emulation.
>
>
>  > A few comments:
>  > - 'static' can be applied to a lot of functions
>
>
> I'll search for these.
>
>
>  > - instead of including linux/usb_ch9.h, you should define the
>  > structures, like in usb-linux.c
>
>
> No problem.
>
>
>  > - while the daemon is linux specific, the remote protocol looks like
>  > host OS neutral, so it should not be too tightly tied to usb-linux.c
>
>
> The protocol is still in its pre-draft status.

I meant that also Windows and BSD clients could in theory use a USB
device from the Linux-only server, so the client end of the protocol
should be independent from usb-linux.c.

>  > - name __ioctl looks like it could clash with system defines and it's
>  > not very descriptive
>
>
> Will changed (Do you have an idea how to name it?).

USBRemoteIOCTLFunc?

>  > - USB_REMOTE_MAGIC is not endian neutral, or is that the purpose?
>
>
> I didn't understand. Do you mean that the value might change if qemu is 
> running on a different type of CPU?

Yes. That would cause problems if the server is different endian from
the client. In fact the whole protocol looks like it also assumes that
the server and client are same endian.