Re: [Qemu-devel] [PATCH] Davicom DM9000 emulation

[Daniel Silverstone]

On Mon, 2008-10-13 at 15:34 +0100, Paul Brook wrote:
> > Also, it appears that some devices don't have the headers required for
> > target_phys_addr_t included before they include devices.h so I had to
> > use an #ifdef around the dm9000_init declaration. If this isn't right
> > then I need to know what the right thing to include in such drivers is.
> > It seems a bit unfortunate to force other drivers to include headers
> > they were otherwise managing without.
> Using target_phys_addr_t is a lie. Your device only implements 32 bits of 
> address space.

The implementation only allows for the two registers to be up to a
32-bit address space apart, but it allows for the base of the device to
be at any part of the target's physical address space. It's not
unreasonable IMO. If you think it is, then I can reduce it to uint32_t
but that loses semantic information regarding the base address (that it
is physical).

Regards,

Daniel.

-- 
Daniel Silverstone                              http://www.simtec.co.uk/
PGP mail accepted and encouraged.            Key Id: 2BC8 4016 2068 7895