[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] implement CLONE_CHILD_CLEARTID
From: |
Lauro Ramos Venancio |
Subject: |
Re: [Qemu-devel] [PATCH] implement CLONE_CHILD_CLEARTID |
Date: |
Thu, 16 Oct 2008 11:28:25 -0300 |
On Thu, 2008-10-16 at 14:19 +0100, Paul Brook wrote:
> Using the host set_tid_address is wrong. This is liable to break the host
> libc/libpthread. The current set_tid_address implementation is similarly
> broken.
I know that the clone implementation is far from the perfection and it
is very hard to implement all the clone flags using a high level API
(pthread).
This patch doesn't break seriously the host libc/libpthread. Pthread
uses the tid_address only for pthread_join. So, actually, this patch
breaks the host pthread_join (and pthread_timedjoin_np), but it makes
the emulated pthread_join work. As the qemu doesn't use pthread_join, I
think it worth to apply this patch.
--
Lauro Ramos Venancio
INdT - Instituto Nokia de Tecnologia
signature.asc
Description: This is a digitally signed message part