[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Broken USB support for Linux host

From: Anthony Liguori
Subject: Re: [Qemu-devel] Broken USB support for Linux host
Date: Tue, 21 Oct 2008 08:39:05 -0500
User-agent: Thunderbird (X11/20080925)

Bjorn Danielsson wrote:
Hello everyone, this is a bug report with a suggested patch included.

Summary: usb_host_scan() in usb-linux.c doesn't handle the logic
correctly when looking for different places to find bus/usb/devices.

Environment: qemu revision 5499 on slamd64 (slackware) 12.1

Symptom: no "host:" usb devices are available at all on any system
where /proc/bus/usb/devices exists.

Diagnosis: the else clause for the USB_FS_SYS case is wrong.

Thanks for narrowing this down.

Please include a Signed-off-by so we can include your patch.


Anthony Liguori


Index: usb-linux.c
--- usb-linux.c (revision 5499)
+++ usb-linux.c (working copy)
@@ -1293,7 +1293,8 @@
             usb_fs_type = USB_FS_SYS;
             dprintf(opened, USBSYSBUS_PATH, devices);
-        } else {
+        }
+        if (!usb_fs_type) {
             term_printf("husb: unable to access USB devices\n");
             goto the_end;


reply via email to

[Prev in Thread] Current Thread [Next in Thread]