[Qemu-devel] Re: [PATCH 17/32] build list of available accelerators

[Avi Kivity]

Glauber Costa wrote:
> From: Glauber Costa <address@hidden>
>
> instead of hardcoding kqemu_start() in exec.c, which would require
> such a hack for all available accelerators, semantics of register_qemu_accel()
> is changed a little bit. It only builds a list of available accelerators.
> The last one registered is the first tried.
>
> This is a temporary solution, since we don't control exactly the order in which
> things are loaded by the constructor attributes. The final goal is to have 
> command
> line switches and priority lists to determine that.
>
> "info accelerator" is changed to accomodate it. It now prints a list of 
> available
> accelerators, and only if one of them is active, a detailed description of it 
> is printed.
>
>  #define MAX_INFO_BUF 1024
>  
>  typedef struct QEMUAccel {
> +    char *name;
>   

const, or warnings you get.

>  
> +typedef struct QEMUCont {
> +    QEMUAccel *acc;
> +    int active;
> +    struct QEMUCont *next;
> +} QEMUCont;
>   

The name is unclear.  But you could fold the structure into QEMUAccel, no?

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.