Re: [Qemu-devel] [5275] Suppress gcc 4.x -Wpointer-sign (included in -Wall) warnings

[Ian Jackson]

Blue Swirl writes ("[Qemu-devel] [5275] Suppress gcc 4.x -Wpointer-sign 
(included in -Wall) warnings"):
> -        ret = sprintf(phys_ram_base + (16 << 20) - 256,
> +        ret = sprintf((char *)(phys_ram_base + (16 << 20) - 256),

I realise I'm a bit late with this comment (my apologies), but:

I think this shows that it would be better to suppress the warning
with the appropriate compiler option, than to try to update the code.

IMO the warning is a mistake since representational compatibility
between corresponding signed and unsigned types is certain for any
platform qemu could plausibily support.

And these kind of casts are dangerous because they can suppress
serious warnings about pointer/integer mismatch.

Ian.