[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH][RFC] Run time TCGv size check for debugging
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH][RFC] Run time TCGv size check for debugging |
Date: |
Wed, 29 Oct 2008 22:06:59 +0200 |
On 10/29/08, Paul Brook <address@hidden> wrote:
> On Wednesday 29 October 2008, Blue Swirl wrote:
> > Hi,
> >
> > When emulating a mixed 32/64 bit Qemu target CPUs it's easy to confuse
> > the TCGv size, passing 32 bit TCGv to a function expecting a 64 bit
> > one and vice versa. This patch adds a run time sanity check for TCGv
> > sizes.
>
>
> Would it make more sense to push these down into tcg_gen_op* ?
How? At that point we don't know what was the correct size.
> tcg-op.h is already fairly unwieldy.
True, and as debugging TCGv will not be common, I'm not sure whether
the patch is worth committing.
> I wonder if it's worth adding TCG_LOW to enable checking on 32-bit hosts.
>
> For futureproofing I'd name things FOO_I32 rather than FOO_32.
Good point, will fix.