qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Qemu-devel] Preliminary patch to implement ehci


From: Mark Burkley
Subject: RE: [Qemu-devel] Preliminary patch to implement ehci
Date: Thu, 30 Oct 2008 16:43:49 -0000

Hi Anthony,

I have ehci built against trunk now but I am seeing an issue with a memory
key I am using for testing.  ioctl returns EPIPE (which I would have thought
was a STALL) to an asynchronous IN completion in usb-linux.c but then this
is returned as USB_RET_NAK to EHCI which confuses my WinXP target because
the transfer is then never completed.

Can I just check that it was intentional to return NAK for EPIPE returns in
asynchronous completions?  If so, then I will try to detect the stall in my
implementation and treat differently to a NAK.  It's just that if I modify
usb-linux.c to return USB_RET_STALL on -EPIPE then it works fine.

Thanks,

Mark


-----Original Message-----
From: address@hidden
[mailto:address@hidden On Behalf Of Anthony
Liguori
Sent: 27 October 2008 14:01
To: address@hidden
Subject: Re: [Qemu-devel] Preliminary patch to implement ehci

Mark Burkley wrote:
> Hi folks,
>
> Just checking, did anyone get a chance to look at this?
>
> Any suggestions for next steps?  Should I post a patch against trunk?
>   

Submitting the patch against 0.9.1 is a non-starter.  0.9.1 is at least 
a year old and the USB code has been majorly refactored.  If you want 
people to review it, it has to be against trunk.

Also make sure that you include a [PATCH] in your subject.  Otherwise, 
it's easily missed on the list.

Regards,

Anthony Liguori

> Thanks,
>
> Mark
>   








reply via email to

[Prev in Thread] Current Thread [Next in Thread]