[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [Bochs-developers] [PATCH 2/6] Add S3 state to DSDT. Ha
From: |
Kevin O'Connor |
Subject: |
[Qemu-devel] Re: [Bochs-developers] [PATCH 2/6] Add S3 state to DSDT. Handleresumeevent in the BIOS. |
Date: |
Sun, 2 Nov 2008 19:03:40 -0500 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Mon, Nov 03, 2008 at 12:28:08AM +0100, Sebastian Herbszt wrote:
> Kevin O'Connor wrote:
>> On Thu, Oct 30, 2008 at 11:41:28PM +0100, Sebastian Herbszt wrote:
>>> It should not return if BX_USE_EBDA_TABLES is defined.
>> BX_USE_EBDA_TABLES is broken. I think we'd be better off removing it
>> instead of adding more to it.
>
> Can you define "broken"?
Well, I think you answered your own question. However, I'm aware of
the following problems:
1 - it uses memory that clashes with the ipl table
2 - it places the smbios in the ebda, but the smbios spec states it
must be located in the 0xf0000 segment.
3 - from a style point of view, it's rather ugly to spread ifdefs
throughout the code - if having bios tables in ebda is desired,
then wrapper functions should be introduced
4 - it's an unnecessary complication - writing to 0xf0000 works. Why
maintain code that is unneeded and doesn't work?
-Kevin