Re: [Qemu-devel] [PATCH 0 of 2] sdl usability improvements

[Stefano Stabellini]

Anthony Liguori wrote:

> Click-to-grab gets disabled when using -usbdevice tablet.


Argh, I wasn't aware of this.
Better this way, no need for a new (ugly) command line option.

 

> I don't fully grok how this makes things better.  This seems like a
> nasty little hack too.  When you leave the window, the mouse disappears
> into one side of the screen, and when you come back, you have to move to
> where ever you were previously.
> 
> I understand how this could be useful with -no-grab, but this would
> defeat the sort of behavior that I commonly rely on when using grab
> (ungrab with a mouse in a convenient place, then come back and click on
> a button).
> 
> What's the user experience you are aiming for here?

The pointer-hide patch is useful if you have more than an open qemu window
and you are moving your mouse between them: you don't want to see more than
a pointer on screen.


> The later mouse hiding patch makes more sense in absolute mode. 
> However, the current patch doesn't limit itself to absolute mode.  I
> would consider that a requirement for merging.
> 

The changes you suggested make good sense, I'll repost only the second patch
with this change.