Re: [Qemu-devel] [PATCH 5/5] vga optimization.

[Stefano Stabellini]

Glauber Costa wrote:

>> @@ -2102,6 +2122,11 @@ static void vga_map(PCIDevice *pci_dev, int 
>> region_num,
>>     } else {
>>         cpu_register_physical_memory(addr, s->vram_size, s->vram_offset);
>>     }
>> +
>> +    s->map_addr = addr;
>> +    s->map_end = addr + VGA_RAM_SIZE;
>> +
>> +    vga_dirty_log_start(s);
>>  }
>>
>> I think you should set lfb_addr and lfb_end here instead of map_addr and
>> map_end.
>>
> It is possible for the lfb to be set, but not mapped.
> So map_addr is what really indicates we're interested in tracking this region.
> Or I am totally wrong?
> 

Yes, you are right.
However these changes are in vga_map that is the pci_register_io_region
function, much like cirrus_pci_lfb_map for cirrus.
They are supposed to set the lfb_addr before we remap it.

Besides I just noticed that you should set lfb_addr only in case that
region_num != PCI_ROM_SLOT.