[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [5627] Add KVM support to QEMU
From: |
Christoph Hellwig |
Subject: |
Re: [Qemu-devel] [5627] Add KVM support to QEMU |
Date: |
Wed, 12 Nov 2008 11:42:15 +0100 |
User-agent: |
Mutt/1.3.28i |
On Wed, Nov 05, 2008 at 04:04:33PM +0000, Anthony Liguori wrote:
> +# kvm probe
> +if test "$kvm" = "yes" ; then
> + cat > $TMPC <<EOF
> +#include <linux/kvm.h>
> +#if !defined(KVM_API_VERSION) || \
> + KVM_API_VERSION < 12 || \
> + KVM_API_VERSION > 12 || \
> + !defined(KVM_CAP_USER_MEMORY) || \
> + !defined(KVM_CAP_SET_TSS_ADDR)
> +#error Invalid KVM version
> +#endif
The installed linux/kvm.h has no relatation at all to the currently
running kernel. Please ship a current max API version kvm.h with qemu
and always build against that one, and handle lower API versions at
runtime. Please don't turn mainline qemu kvm support into the same
bloody mess as the kvm userspace repository.