[Qemu-devel] Re: [Bochs-developers] [PATCH v4 2/5] Preserve memory contentduringSMM init.

[Gleb Natapov]

On Sun, Nov 23, 2008 at 10:15:36PM +0100, Sebastian Herbszt wrote:
> Gleb Natapov wrote:
>> On Tue, Nov 18, 2008 at 09:46:28AM +0200, Gleb Natapov wrote:
>>> > SMBASE is not relocated. If i don't mistake smm_init() should be run on S3
>>> > resume and we would need something like
>>> >
>>> > pci_for_each_device(find_piix4pm)
>>> > if (piix4pm_pcidev)
>>> >    smm_init();
>>> >
>>> > in the resume path in rombios32.c.
>>> >
>>> Yes, you are right. I'll add it.
>>>
>> What about this? (fixed version of 1/5 patch)
>
> Looks good.
> Do you intend to implement piix4_pm_reset() for qemu so register DEVACTB
> is reset on qemu_system_reset_request()?
>
Sure, why not.

--
                        Gleb.