[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 4 of 5] [UPDATE] DisplayState interface change

From: Stefano Stabellini
Subject: Re: [Qemu-devel] [PATCH 4 of 5] [UPDATE] DisplayState interface change
Date: Mon, 24 Nov 2008 16:51:12 +0000
User-agent: Thunderbird (X11/20080505)

Anthony Liguori wrote:

> I think we need another intermediate step here.
> Right now, we have a pretty poor abstraction wrt QEMUConsole and
> DisplayState.  QEMUConsole is known to much of the hardware emulation
> but DisplayState is too.


> I think we need a step that replaces all notions of QEMUConsole in
> hw/*.c with DisplayState including an appropriate creation functions. 
> There's really no point in passing a DisplayState to the hardware
> devices, instead they should be allocating it and returning it to be
> passed to the SDL/VNC front-ends.

If am not mistaken this is exactly what Paul proposed.
As I said before, this model is certainly more elegant, but presents
some hidden issues:

what do we do with the text consoles?
Right now a single DisplayState is shared between a graphic console and
multiple text console.
Do we really want to allocate a buffer each?
Who is going to do the console multiplexing?

Even though the QEMUConsole abstraction is not very elegant and should
probably be improved I believe it is a different and independent issue
from the one addressed in this series.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]