[Qemu-devel] Re: [PATCH] handle MAP_FLAGMASK

[Blue Swirl]

On 11/26/08, Christoph Egger <address@hidden> wrote:
>
>  Hi,
>
>  NetBSD doesn't have MAP_FLAGMASK. Attached patch fixes this.

The code blindly uses native definitions, but the BSDs differ in some cases.

FreeBSD:
#define MAP_HASSEMAPHORE 0x0200 /* region may contain semaphores */
#define MAP_STACK        0x0400 /* region grows down, like a stack */
#define MAP_NOSYNC       0x0800 /* page to but do not sync underlying file */

NetBSD:
#define MAP_HASSEMAPHORE 0x0200 /* region may contain semaphores */
#define MAP_TRYFIXED     0x0400 /* attempt hint address, even within break */
#define MAP_WIRED        0x0800 /* mlock() mapping when it is established */

OpenBSD:
#define MAP_HASSEMAPHORE 0x0200 /* region may contain semaphores */
#define MAP_TRYFIXED     0x0400 /* attempt hint address, even within heap */

Same for madvise flags.

So we need TARGET_FREEBSD_MAP_HASSEMAPHORE etc. and specific handling
for each OS, like the syscalls are handled.