Re: [Qemu-devel] [PATCH 01/13] hw/ppc.c: LOG_IRQ macro

[Anthony Liguori]

Eduardo Habkost wrote:
> This macro will avoid some #ifdefs in the code and create a single point
> where the logging call can be changed in the future.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
>  hw/ppc.c |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/hw/ppc.c b/hw/ppc.c
> index 60d6e86..cbd69e0 100644
> --- a/hw/ppc.c
> +++ b/hw/ppc.c
> @@ -31,6 +31,16 @@
>  //#define PPC_DEBUG_IRQ
>  //#define PPC_DEBUG_TB
>  
> +#ifdef PPC_DEBUG_IRQ
> +#  define LOG_IRQ(...) do {           \
> +     if (loglevel & CPU_LOG_INT)      \
> +       fprintf(logfile, __VA_ARGS__); \
> +   } while (0)
> +#else
> +#  define LOG_IRQ(...) do { } while (0)
> +#endif
>   

This style of macro is less ideal than:

#define LOG_IRQ(fmt, ...) fprintf(logfile, fmt, ## __VA_ARGS__).

Other than that, this series looks pretty sane.  If you fix these 
macros, I'll apply the series.

Regards,

Anthony Liguori

> +
> +
>  static void cpu_ppc_tb_stop (CPUState *env);
>  static void cpu_ppc_tb_start (CPUState *env);
>  
>