Re: [Qemu-devel] [PATCH 00/31] Logging code cleanup, take 2

[Eduardo Habkost]

On Fri, Dec 12, 2008 at 06:25:44PM +0200, Blue Swirl wrote:
> On 12/12/08, Eduardo Habkost <address@hidden> wrote:
> > This is a new take of the patches for cleaning up qemu logging/debugging
> >  code. The series grow a little, as I've macrofied more #ifdefs on other
> >  files. I've also changed the macros to use 'foo(bar, ## __VA_ARGS__)'
> >  instead of 'foo(bar, __VA_ARGS__)', as suggested by Anthony.
> 
> Do you plan to convert Sparc too?

My initial goal is to improve qemu logging so that we can easily change
the way messages are logged (e.g. add timestamps to the log messages,
or use other logging methods). This debugging code cleanup was just one
step for reaching this goal.

Most of the debugging #ifdefs on target-sparc are using printf()
or fprintf(stderr), and the few 'logfile' occurrences are not easily
converted to a single macro, so I didn't change it (yet).

In addition to logging improvements, the debugging code can be unified.
When that happens, I am sure sparc will be changed.

-- 
Eduardo