Re: [Qemu-devel] [PATCH] Fix crash on 'info vnc' after 'change vnc none'

[Aurelien Jarno]

On Wed, Nov 12, 2008 at 10:38:36AM -0800, James Ko wrote:
> I propose the following patch to prevent crash in call to 
> term_print_filename
> with NULL vnc_state->display argument from do_info_vnc.
> 
> vnc_state->display is set to NULL after "change vnc none" but vnc_state 
> itself
> is still valid.
> 
> James

Thanks, applied.

> 
> diff -aru a/qemu/vnc.c b/qemu/vnc.c
> --- a/qemu/vnc.c  2008-08-21 17:46:40.000000000 -0700
> +++ b/qemu/vnc.c  2008-11-06 14:31:51.000000000 -0800
> @@ -180,7 +180,7 @@
> 
>  void do_info_vnc(void)
>  {
> -    if (vnc_state == NULL)
> +    if (vnc_state == NULL || vnc_state->display == NULL)
>       term_printf("VNC server disabled\n");
>      else {
>       term_printf("VNC server active on: ");
> 
> 
> 

-- 
  .''`.  Aurelien Jarno             | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   address@hidden         | address@hidden
   `-    people.debian.org/~aurel32 | www.aurel32.net