[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 4/8] v2: extend parser to parse pin: option
From: |
Anthony Liguori |
Subject: |
[Qemu-devel] Re: [PATCH 4/8] v2: extend parser to parse pin: option |
Date: |
Tue, 16 Dec 2008 18:19:18 -0600 |
User-agent: |
Thunderbird 2.0.0.17 (X11/20080925) |
Andre Przywara wrote:
Anthony Liguori wrote:
Andre Przywara wrote:
Signed-off-by: Andre Przywara <address@hidden>
I think we suggested that this should be specified in a different
option than -numa to separate the host/guest configuration bits.
As I said in the beginning of 0/8, I don't think that makes much sense.
Do you want this to be independent of the rest of NUMA (guest) code?
Then this is a different story.
I'm not sure I see what you're asking.
The purpose of this code is to pin _multiple_ guest nodes to
_multiple_ different host nodes, something that is quite intricate to
do otherwise.
Right now, you say:
-numa 2,mem:1G;2G,cpu:0-1;2-3,pin:2;3
My most preferred syntax would be:
-numa node,mem=0G-1G,cpu=0-1,nodeid=0 -numa pin,nodeid=0,hostid=2 \
-numa node,mem=1G-3G,cpu=2-3,nodeid=1 -numa pin,nodeid=1,hostid=3
It's more typing, but it maps really well to how -net tap works and how
-drive works. It has a lot less special characters too. I'm not saying
this is the only right solution, but this is probably what I would do if
I were writing this.
Please tell me your opinion (and maybe a concrete suggestion on which
syntax to use).
Regards,
Andre.
P.S. Do you agree to Avi that the colon should be substituted by an
equal-sign?
Yes.
Regards,
Anthony Liguori