|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] Re: [PATCH] optionally specify vm stop message |
Date: | Fri, 16 Jan 2009 10:27:46 -0600 |
User-agent: | Thunderbird 2.0.0.19 (X11/20090105) |
Jan Kiszka wrote:
Anthony Liguori wrote:Also non zero reasons a handled differently by vm_stop. Don't know why.It's an ugly hack for gdbstub. It notifies gdb when a breakpoint occurs. We have far too many state tracking mechanisms. Anyway, gdb can pass something like VM_STOP_BP and that can be used to trigger the callback.It's not only used for breakpoints but any stop condition that should be reported to the gdb frontend (so far: EXCP_DEBUG and EXCP_INTERRUPT). Not sure, though, how to deal with ENOSPC - it's not a guest fault, it's a host problem. From that POV, gdb should not receive it.
We already have a vm_change_state_handler that is invoked whenever a guest starts running or stops running. gdb should be able to use that and look at env->exception_index, no?
Regards, Anthony Liguori
Nevertheless, gdb_vm_stopped should better do the filtering, not the caller of vm_stop by passing 0 for "any other reason gdb should be bothered with". Jan
[Prev in Thread] | Current Thread | [Next in Thread] |