[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 8/9] New option -audio as a more flexible altern
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 8/9] New option -audio as a more flexible alternative to -soundhw |
Date: |
Fri, 23 Jan 2009 11:24:50 +0100 |
User-agent: |
Thunderbird 2.0.0.17 (X11/20080922) |
Markus Armbruster schrieb:
> Kevin Wolf <address@hidden> writes:
>
>> Markus Armbruster schrieb:
>>> malc <address@hidden> writes:
>>>
>>>> On Thu, 22 Jan 2009, Markus Armbruster wrote:
>>>>
>>>>> From: Markus Armbruster <address@hidden>
>>>>>
>>>>> This is in preparation of pci=... support for audio devices. -soundhw
>>>>> doesn't support the common name=value,... syntax.
>>>>> ---
>>>>> sysemu.h | 1 +
>>>>> vl.c | 94
>>>>> ++++++++++++++++++++++++++++++++++++++++++++-----------------
>>>>> 2 files changed, 69 insertions(+), 26 deletions(-)
>>>> This as, i guess, the rest of the patches is tab damaged. The
>>>> documentation wasn't updated either.
>>>>
>>>> [..snip..]
>>> It's just a sketch. How would you like your tabs?
>> Probably four spaces, just like in the surrounding code (as almost
>> everywhere in qemu).
>>
>> Kevin
>
> Can't see where I got that wrong.
>
> Any preference on use of the tab character?
Most of the qemu code only uses spaces, no real tabs.
Kevin
- [Qemu-devel] [PATCH 9/9] Support pci=... in option argument of -audio, (continued)
- [Qemu-devel] [PATCH 9/9] Support pci=... in option argument of -audio, Markus Armbruster, 2009/01/22
- [Qemu-devel] [PATCH 3/9] Support pci=... in option argument of -vga, Markus Armbruster, 2009/01/22
- [Qemu-devel] [PATCH 2/9] Clean up handling of name=value, ... part of -vga option argument, Markus Armbruster, 2009/01/22
- [Qemu-devel] [PATCH 5/9] Support pci=... in option argument of -net nic, Markus Armbruster, 2009/01/22
- [Qemu-devel] [PATCH 4/9] Convert virtio_init_pci() to pci_register_device_2(), Markus Armbruster, 2009/01/22
- [Qemu-devel] [PATCH 8/9] New option -audio as a more flexible alternative to -soundhw, Markus Armbruster, 2009/01/22
[Qemu-devel] [PATCH 1/9] PCI device registration helpers, Markus Armbruster, 2009/01/22
[Qemu-devel] [PATCH 7/9] Support pci=... in option argument of -drive if=virtio, Markus Armbruster, 2009/01/22
[Qemu-devel] [PATCH 6/9] Make drives_opt[] accessible from device initialization, Markus Armbruster, 2009/01/22
Re: [Qemu-devel] [RFC PATCH 0/9] Configurable PCI device addresses, Anthony Liguori, 2009/01/22