[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 6/8] qemu:virtio-net: Enable filtering based

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH v2 6/8] qemu:virtio-net: Enable filtering based on MAC, promisc, broadcast and allmulti
Date: Tue, 03 Feb 2009 14:53:31 -0600
User-agent: Thunderbird (X11/20090105)

Blue Swirl wrote:
On 2/3/09, Alex Williamson <address@hidden> wrote:
Make use of the new RX_MODE control virtqueue class by dropping
 packets the guest doesn't want to see.

 Signed-off-by: Alex Williamson <address@hidden>

 +    static uint8_t bcast[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};


It may be good practice but practically speaking, I don't think it will generate different code. The only thing that uses bcast is memcmp() which should be a builtin. Since bcast doesn't otherwise escape the function, it's an obvious candidate for optimization. I think the compiler already has enough information that const doesn't tell it anything more.


Anthony Liguori

reply via email to

[Prev in Thread] Current Thread [Next in Thread]