Re: [Qemu-devel] [PATCH] don't expose lm bit if kernel is not 64-bit capable.

[Glauber Costa]

On Tue, Feb 3, 2009 at 7:14 PM, Anthony Liguori <address@hidden> wrote:
> Glauber Costa wrote:
>>>
>>> It would be better to use KVM_GET_SUPPORTED_CPUID for this (and similar).
>>>  uname() can lie, and in theory kvm can support x86_64 on i386 kernels
>>> (although patches to implement this would be rejected on cost/benefit and
>>> aesthetic concerns).
>>>
>>
>> I sent a patch that implements this last week, but anthony seemed to
>> be more inclined
>> towards this approach.
>>
>
> All I said was that if we used KVM_GET_SUPPORTED_CPUID, we had to do
> something about save/restore since it can mask arbitrary things.
>
Then I misread you.

Who's the subject of your sentence, that can mask arbitrary things?
kvm.ko in its ioctl,
or save/restore?

-- 
Glauber  Costa.
"Free as in Freedom"
http://glommer.net

"The less confident you are, the more serious you have to act."