[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [6609] Parse full PCI device addresses (Markus Armbrust
|
From: |
Paul Brook |
|
Subject: |
Re: [Qemu-devel] [6609] Parse full PCI device addresses (Markus Armbruster) |
|
Date: |
Thu, 12 Feb 2009 15:39:26 +0000 |
|
User-agent: |
KMail/1.9.9 |
> This code parses full PCI device addresses. It then rejects domains
> other than zero, because these are not supported in QEMU.
>...
> + * Parse [[<domain>:]<bus>:]<slot>, return -1 on error
> + */
> +static int pci_parse_devaddr(const char *addr, int *domp, int *busp,
> unsigned *slotp) +{
If we're rejecting nonzero domains then having the parse routine return a
domain value seems wrong. It's just going to make it harder to verify correct
operation when domains are implemented.
Paul