[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter |
Date: |
Fri, 13 Feb 2009 12:40:20 +0000 |
User-agent: |
KMail/1.9.9 |
> - A device requests a filter and is told if the request is successful
> - On success the device may skip it's own filtering
> - If another vlan client is added, the following _must_ occur:
> - The "filterer" must clear (remove) the filter
> - The "filteree" must revert to using their own filtering
> - If a vlan client is removed, the following _may_ occur:
> - vlan clients are notified that they may retry their filter
>..
> The added()/removed() interface feels like the right solution to this.
I think your analysis is fundamentally flawed. Firstly I'm not sure the above
holds when going between 1 and 2 clients on a vlan. Even ignoring that, you
are making implicit assumptions about when a filter will succeed. If these
assumptions are broken (which seems likely if we ever implement filtering
with more than 2 devices on a vlan) they you'll get subtle breakage in every
single user of the API.
> We could use a changed() function, but it would need to know the
> direction of the change, which leads back to the same mechanics. If
> there's a better way, please suggest it. Thanks,
I still don't see why the device needs to know what's changed. The response
should always be the same: Request a filter, and see if it works.
Paul
- [Qemu-devel] [PATCH 0/4] qemu: TAP filtering support, Alex Williamson, 2009/02/10
- [Qemu-devel] [PATCH 1/4] qemu:net: Add infrastructure for setting an RX filter through the vlan, Alex Williamson, 2009/02/10
- [Qemu-devel] [PATCH 2/4] qemu:net: Add TAP support for RX filtering on Linux, Alex Williamson, 2009/02/10
- [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter, Alex Williamson, 2009/02/10
- Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter, Paul Brook, 2009/02/12
- Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter, Alex Williamson, 2009/02/12
- Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter, Paul Brook, 2009/02/12
- Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter, Alex Williamson, 2009/02/12
- Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter, Jamie Lokier, 2009/02/12
- Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter,
Paul Brook <=
- Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter, Jamie Lokier, 2009/02/13
- Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter, Paul Brook, 2009/02/13
- Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter, Jamie Lokier, 2009/02/13
- Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter, Paul Brook, 2009/02/13
- Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter, Jamie Lokier, 2009/02/13
- Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter, Paul Brook, 2009/02/15
[Qemu-devel] [PATCH 4/4] qemu:e1000: Add support for qemu_vlan_rxfilter, Alex Williamson, 2009/02/10
[Qemu-devel] Re: [PATCH 0/4] qemu: TAP filtering support, Mark McLoughlin, 2009/02/11