[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/7] clean build: Fix remaining cris warnings
From: |
Laurent Desnogues |
Subject: |
Re: [Qemu-devel] [PATCH 5/7] clean build: Fix remaining cris warnings |
Date: |
Sun, 22 Feb 2009 00:13:02 +0100 |
On Sun, Feb 22, 2009 at 12:03 AM, Stuart Brady <address@hidden> wrote:
> On Sat, Feb 21, 2009 at 08:00:55PM +0100, Jan Kiszka wrote:
>> diff --git a/target-cris/translate.c b/target-cris/translate.c
>> index f575e63..954b038 100644
>> --- a/target-cris/translate.c
>> +++ b/target-cris/translate.c
>> @@ -2613,7 +2613,7 @@ static unsigned int dec_move_pm(DisasContext *dc)
>> static unsigned int dec_movem_mr(DisasContext *dc)
>> {
>> TCGv_i64 tmp[16];
>> - TCGv tmp32;
>> + TCGv tmp32 = 0;
>> TCGv addr;
>> int i;
>> int nr = dc->op2 + 1;
>
> Hmm, GCC just gets it wrong here -- and 0 isn't really very meaningful.
> At the very least, shouldn't there be a comment? Something like Linux's
> uninitialized_var() macro might be worth considering...
Some targets use TCGV_UNUSED_I32/I64. I would initialize tmp32
to that value in an additional else part to the first if (nr & 1). That
should silence gcc.
Laurent
- [Qemu-devel] [PATCH 0/7] clean build - eliminate warnings, Jan Kiszka, 2009/02/21
- [Qemu-devel] [PATCH 1/7] clean build: Add bt_host_hci prototype, Jan Kiszka, 2009/02/21
- [Qemu-devel] [PATCH 6/7] clean build: Fix remaining m68k warnings, Jan Kiszka, 2009/02/21
- [Qemu-devel] [PATCH 2/7] clean build: Fix irq_info and pic_info related warnings, Jan Kiszka, 2009/02/21
- [Qemu-devel] [PATCH 7/7] clean build: Fix remaining sh4 warnings, Jan Kiszka, 2009/02/21
- [Qemu-devel] [PATCH 3/7] arm: Fix gic_irq_state.level bitfield type, Jan Kiszka, 2009/02/21
- [Qemu-devel] [PATCH 4/7] clean build: Fix arm build warnings, Jan Kiszka, 2009/02/21
- [Qemu-devel] [PATCH 5/7] clean build: Fix remaining cris warnings, Jan Kiszka, 2009/02/21
- Re: [Qemu-devel] [PATCH 5/7] clean build: Fix remaining cris warnings, Paul Brook, 2009/02/21
Re: [Qemu-devel] [PATCH 0/7] clean build - eliminate warnings, Laurent Desnogues, 2009/02/21