[Qemu-devel] Re: [PATCH 5/5] kvm/powerpc: flat device tree files for MPC8544DS

[Hollis Blanchard]

On Thu, 2009-02-26 at 18:35 +0800, Liu Yu wrote:
> mpc8544ds.dts is copied from kerenl.
> Non-supported devices has been removed.
> 
> Signed-off-by: Liu Yu <address@hidden>
> ---
>  pc-bios/mpc8544ds.dtb |  Bin 0 -> 12288 bytes
>  pc-bios/mpc8544ds.dts |  122 
> +++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 122 insertions(+), 0 deletions(-)
>  create mode 100644 pc-bios/mpc8544ds.dtb
>  create mode 100644 pc-bios/mpc8544ds.dts

> 
> diff --git a/pc-bios/mpc8544ds.dts b/pc-bios/mpc8544ds.dts
> new file mode 100644
> index 0000000..872152d
> --- /dev/null
> +++ b/pc-bios/mpc8544ds.dts
> @@ -0,0 +1,122 @@
> +/*
> + * MPC8544 DS Device Tree Source
> + *
> + * Copyright 2007, 2008 Freescale Semiconductor Inc.
> + *
> + * This program is free software; you can redistribute  it and/or modify it
> + * under  the terms of  the GNU General  Public License as published by the
> + * Free Software Foundation;  either version 2 of the  License, or (at your
> + * option) any later version.
> + */
> +
> +/dts-v1/;
> +/ {
> +     model = "MPC8544DS";
> +     compatible = "MPC8544DS", "MPC85xxDS";
> +     #address-cells = <1>;
> +     #size-cells = <1>;
> +
> +     aliases {
> +             serial0 = &serial0;
> +             serial1 = &serial1;
> +             pci0 = &pci0;
> +     };
> +
> +     cpus {
> +             #address-cells = <1>;
> +             #size-cells = <0>;
> +
> +             PowerPC,address@hidden {
> +                     device_type = "cpu";
> +                     reg = <0x0>;
> +                     d-cache-line-size = <32>;       // 32 bytes
> +                     i-cache-line-size = <32>;       // 32 bytes
> +                     d-cache-size = <0x8000>;                // L1, 32K
> +                     i-cache-size = <0x8000>;                // L1, 32K
> +                     timebase-frequency = <0>;
> +                     bus-frequency = <0>;
> +                     clock-frequency = <0>;

It might be helpful to comment that these properties are overwritten at
runtime.

> +             };
> +     };
> +
> +     memory {
> +             device_type = "memory";
> +             reg = <0x0 0x0>;        // Filled by U-Boot
> +     };

"Filled by qemu"

> +     address@hidden {
> +             #address-cells = <1>;
> +             #size-cells = <1>;
> +             device_type = "soc";
> +             compatible = "simple-bus";
> +
> +             ranges = <0x0 0xe0000000 0x100000>;
> +             reg = <0xe0000000 0x1000>;      // CCSRBAR 1M
> +             bus-frequency = <0>;            // Filled out by uboot.

Not filled by anybody...

Anyways, these are minor cosmetic issues; I'd be happy if the patch were
committed in its current form.

Acked-by: Hollis Blanchard <address@hidden>

-- 
Hollis Blanchard
IBM Linux Technology Center