[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH][RFC] Handling ':' on filenames
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PATCH][RFC] Handling ':' on filenames |
Date: |
Fri, 6 Mar 2009 18:28:30 -0300 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
This patch fixes this issue:
$ qemu-img create -f qcow2 /tmp/a:b 1G
$ qemu-system-x86_64 -hda qcow2:/tmp/a:b
qemu: could not open disk image /tmp/a:b
$
Based on a suggestion by Daniel Berrange.
However, this is still just a workaround. The semantics of filenames
containing colon characters (and how this can be escaped, avoided,
or worked around) are not very clear.
Going further, what if we stop using "protocol:filename" strings
internally, except where the user interface or external data really
requires this format?
Signed-off-by: Eduardo Habkost <address@hidden>
---
block.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/block.c b/block.c
index 7c744c7..04488d6 100644
--- a/block.c
+++ b/block.c
@@ -236,6 +236,14 @@ static BlockDriver *find_protocol(const char *filename)
is_windows_drive_prefix(filename))
return &bdrv_raw;
#endif
+
+ /* Protocol name will never start with a slash.
+ * This allows the user to specify absolute filenames
+ * containing a ":" character.
+ */
+ if (*filename == '/')
+ return &bdrv_raw;
+
p = strchr(filename, ':');
if (!p)
return &bdrv_raw;
--
1.6.1
--
Eduardo
- [Qemu-devel] [PATCH][RFC] Handling ':' on filenames,
Eduardo Habkost <=