[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [6721] Refactor keymap code to avoid duplication ("Dani
From: |
Johannes Schindelin |
Subject: |
Re: [Qemu-devel] [6721] Refactor keymap code to avoid duplication ("Daniel P. |
Date: |
Sat, 7 Mar 2009 03:52:32 +0100 (CET) |
User-agent: |
Alpine 1.00 (DEB 882 2007-12-20) |
Hi,
On Fri, 6 Mar 2009, Stefan Weil wrote:
> Anthony Liguori schrieb:
> > Revision: 6721
> > http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6721
> > Author: aliguori
> > Date: 2009-03-06 20:27:10 +0000 (Fri, 06 Mar 2009)
> > Log Message:
> > -----------
> > Refactor keymap code to avoid duplication ("Daniel P. Berrange")
> >
> > Each of the graphical frontends #include a .c file, for keymap code
> > resulting in duplicated definitions & duplicated compiled code. A
> > couple of small changes allowed this to be sanitized, so instead of
> > doing a #include "keymaps.c", duplicating all code, we can have a
> > shared keymaps.h file, and only compile code once. This allows the
> > next patch to move the VncState struct out into a header file without
> > causing clashing definitions.
> >
> >
>
>
> The new file keymaps.h is missing.
Anthony, as you seem to use Git from time to time, you might be interested
in using git-svn, to overcome such omissions.
Hth,
Dscho