Re: [HaikuPorts-devs] [Qemu-devel] Re: [PATCH] [RFC] Haiku host support and general configure issues

[François Revol]

> François Revol wrote:
> >> We could define a qemu_errno() which returns errno converted to
> >> positive
> >> numbers.  While it will touch a lot of places, I don't think it
> > > can
> >> be
> >> considered invasive.
> >>
> >
> > I'm used to using the opposite, RETERR() returning always negative
> > codes from either errno or E*, and it works quite well.
> >
> > I don't see the point in making stuff positive to return them
> > negated.
> >
>
> Changing errno to qemu_errno() is not an invasive change (at least,
> not
> much).  Adding a RETERR() is, with significant chance for
> regressions.

Except it's not enough.
It's _not_ only errno that is < 0, but the E* codes too.
so all return -EFOO are indeed broken.

Another option is tu #define other codes from E* like QEINVAL, ...
OSSv4 does this.

Anyway, I'm too busy to look into it yet, will see later.

François.