Re: [Qemu-devel] [PATCH] fix ARMv7 MOV R15, xxx operation

[Paul Brook]

On Friday 13 March 2009, Riihimaki Juha wrote:
> On Mar 13, 2009, at 20:29, ext Paul Brook wrote:
> >> Seems a little bit clumsy approach to duplicate the same piece of
> >> code
> >> in several places imho so if you have any better suggestions...
> >
> > That's the whole point of functions.
>
> Sorry, I was just hoping to avoid duplicating code in several places,
> be that 5 lines of code, a function call, a macro or whatever. But I
> guess no such luck.

We already have a function used for setting the value of a register[1] 
(store_reg). You just need to use a slightly different instruction when that 
write is interworked.

Paul

[1] There are a few other obsolete variants like gen_movl_reg_TN, but they 
need to go away anyway.