Re: [Qemu-devel] Re: SIGSEGV on Windows with KQEMU enabled

[Johannes Schindelin]

Hi,

On Sun, 15 Mar 2009, Paul Brook wrote:

> > > But really funny think is the change that triggers the bug is precisely
> > > this: -Monitor *cur_mon;
> > > +Monitor *cur_mon = NULL;
> > >
> > > Obviously, kqemu is happier having garbage in the cur_mon than NULL
> >
> > I rather expect that to _hide_ the bug.  The "garbage" might be a
> > left-over from the heap.
> 
> This change does precisely nothing. In C all global and static variables 
> are implicitly zero initialized.

True.  I assumed that the lack of indentation was a mailer-induced 
mistake, but looking at the source (which I did not have time to when 
replying myself), you're correct, this initialization is in BSS, and 
therefore implicitly NULL anyway.

So I agree that this change cannot be the regression (except if GCC4 has a 
bug in BSS initialization, which I doubt rather strongly).

Ciao,
Dscho