[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] r6349 broke Commander Keen 4 ;-(
From: |
malc |
Subject: |
Re: [Qemu-devel] r6349 broke Commander Keen 4 ;-( |
Date: |
Tue, 17 Mar 2009 02:08:13 +0300 (MSK) |
On Mon, 16 Mar 2009, Robert Riebisch wrote:
> Hi!
>
> When running Commander Keen 4 (<ftp://ftp.3drealms.com/share/4keen.zip>)
> in DOS only the left half of the VGA screen is shown on the SDL interface.
>
> By doing lots of builds I narrowed the problem down to
> <http://svn.savannah.gnu.org/viewvc?view=rev&root=qemu&revision=6349> by
> Stefano Stabellini.
6349 is indeed what broke stuff, the code was moved (why?) and uses
disp_width that could be modified later..
diff --git a/hw/vga.c b/hw/vga.c
index e3d2446..eeb77f1 100644
--- a/hw/vga.c
+++ b/hw/vga.c
@@ -1619,6 +1619,16 @@ static void vga_draw_graphic(VGAState *s, int
full_update)
s->double_scan = double_scan;
}
+ if (shift_control == 0) {
+ if (s->sr[0x01] & 8) {
+ disp_width <<= 1;
+ }
+ } else if (shift_control == 1) {
+ if (s->sr[0x01] & 8) {
+ disp_width <<= 1;
+ }
+ }
+
depth = s->get_bpp(s);
if (s->line_offset != s->last_line_offset ||
disp_width != s->last_width ||
@@ -1660,7 +1670,6 @@ static void vga_draw_graphic(VGAState *s, int full_update)
full_update |= update_palette16(s);
if (s->sr[0x01] & 8) {
v = VGA_DRAW_LINE4D2;
- disp_width <<= 1;
} else {
v = VGA_DRAW_LINE4;
}
@@ -1669,7 +1678,6 @@ static void vga_draw_graphic(VGAState *s, int full_update)
full_update |= update_palette16(s);
if (s->sr[0x01] & 8) {
v = VGA_DRAW_LINE2D2;
- disp_width <<= 1;
} else {
v = VGA_DRAW_LINE2;
}
--
mailto:address@hidden