[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Document Qemu coding style
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH] Document Qemu coding style |
Date: |
Tue, 31 Mar 2009 19:18:44 +0300 |
On 3/31/09, David Turner <address@hidden> wrote:
> Very frankly, I don't think that a coding style, even strictly applied, is
> going to make the QEMU code
> easier to understand.
>
> The real barriers to understanding are the lack of structure in the code,
> liberal use of global macros
> scattered randomly in the source code, exceedingly liberally named
> functions, and sometimes obscure
> implementation of simple concepts (*cough* CharDriverState), cramming
> totally unrelated stuff in single
> largish source files (vl.c for the win !), and a blatant lack of
> documentation comments for a lot of subtle
> stuff in there to explain the magic.
True enough for the comments part. There are still some areas that I
don't understand well, for example TB handling and its inherent
limitations.
Which part of the source you find subtle and magical but not commented enough?
Maybe we should use Doxygen or hxtool to combine source code and documentation.
- Re: [Qemu-devel] [PATCH] Document Qemu coding style, (continued)
- Re: [Qemu-devel] [PATCH] Document Qemu coding style, Avi Kivity, 2009/03/30
- Re: [Qemu-devel] [PATCH] Document Qemu coding style, Lennart Sorensen, 2009/03/30
- Re: [Qemu-devel] [PATCH] Document Qemu coding style, M. Warner Losh, 2009/03/30
- Re: [Qemu-devel] [PATCH] Document Qemu coding style, Lennart Sorensen, 2009/03/30
- Re: [Qemu-devel] [PATCH] Document Qemu coding style, M. Warner Losh, 2009/03/30
- Re: [Qemu-devel] [PATCH] Document Qemu coding style, Laurent Desnogues, 2009/03/31
- Re: [Qemu-devel] [PATCH] Document Qemu coding style, David Turner, 2009/03/31
- Re: [Qemu-devel] [PATCH] Document Qemu coding style, Avi Kivity, 2009/03/31
- Re: [Qemu-devel] [PATCH] Document Qemu coding style, David Turner, 2009/03/31
- Re: [Qemu-devel] [PATCH] Document Qemu coding style,
Blue Swirl <=
- Re: [Qemu-devel] [PATCH] Document Qemu coding style, David Turner, 2009/03/31
- Re: [Qemu-devel] [PATCH] Document Qemu coding style, malc, 2009/03/31
- Re: [Qemu-devel] [PATCH] Document Qemu coding style, David Turner, 2009/03/31
- Re: [Qemu-devel] [PATCH] Document Qemu coding style, malc, 2009/03/31
- Re: [Qemu-devel] [PATCH] Document Qemu coding style, David Turner, 2009/03/31
- Re: [Qemu-devel] [PATCH] Document Qemu coding style, malc, 2009/03/31
Re: [Qemu-devel] [PATCH] Document Qemu coding style, Avi Kivity, 2009/03/30