[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] Fix (at least one cause of) qcow2 corruption.

From: Nolan
Subject: [Qemu-devel] [PATCH] Fix (at least one cause of) qcow2 corruption.
Date: Tue, 31 Mar 2009 15:40:54 -0700

qcow2's get_cluster_offset() scans forward in the l2 table to find other
clusters that have the same allocation status as the first cluster.
This is used by (among others) qcow_is_allocated().

Unfortunately, it was not checking to be sure that it didn't fall off
the end of the l2 table.  This patch adds that check.

The symptom that motivated me to look into this was that
bdrv_is_allocated() was returning false when there was in fact data
there.  This is one of many ways this bug could lead to data corruption.

I checked the other place that scans for consecutive unallocated blocks
(alloc_cluster_offset()) and it appears to be OK:
    nb_clusters = MIN(nb_clusters, s->l2_size - l2_index);
appears to prevent the same problem from occurring.

Signed-off-by: Nolan Leake <nolan <at> sigbus.net>

Index: block-qcow2.c
--- block-qcow2.c       (revision 6963)
+++ block-qcow2.c       (working copy)
@@ -761,6 +761,10 @@
     nb_available = (nb_available >> 9) + index_in_cluster;
+    if (nb_needed > nb_available) {
+        nb_needed = nb_available;
+    }
     cluster_offset = 0;
     /* seek the the l2 offset in the l1 table */

reply via email to

[Prev in Thread] Current Thread [Next in Thread]