Re: [Qemu-devel] [PATCH] Document QEMU coding style (v2)

[malc]

On Wed, 1 Apr 2009, Edgar E. Iglesias wrote:

> On Tue, Mar 31, 2009 at 08:23:06PM +0300, Avi Kivity wrote:
> > With the help of some Limoncino I noted several aspects of the QEMU coding
> > style, particularly where it differs from the Linux coding style as many
> > contributors work on both projects.
> > 
> > Signed-off-by: Avi Kivity <address@hidden>
> > 
> > Changes from v1:
> >   - s/Qemu/QEMU/
> >   - s/Posix/POSIX/
> >   - note that the _t suffix is not POSIX compliant, and will be changed
> >   - discourage eol whitespace
> >   - be strict about the 80 char line width
> > ---
> >  CODING_STYLE |   78 
> > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 files changed, 78 insertions(+), 0 deletions(-)
> >  create mode 100644 CODING_STYLE
> > 
> > diff --git a/CODING_STYLE b/CODING_STYLE
> > new file mode 100644
> > index 0000000..1ab13b6
> > --- /dev/null
> > +++ b/CODING_STYLE
> > @@ -0,0 +1,78 @@
> > +Qemu Coding Style
> > +=================
> > +
> > +1. Whitespace
> > +
> > +Of course, the most important aspect in any coding style is whitespace.
> > +Crusty old coders who have trouble spotting the glasses on their noses
> > +can tell the difference between a tab and eight spaces from a distance
> > +of approximately fifteen parsecs.  Many a flamewar have been fought and
> > +lost on this issue.
> > +
> > +QEMU indents are four spaces.  Tabs are never used, except in Makefiles
> > +where they have been irreversibly coded into the syntax by some moron.
> > +Spaces of course are superior to tabs because:
> 
> 
> Hi I'd appreciate it if we removed the insults and the arrogance, i.e
> skip the "moron" and the of courses. Other than that most of this stuff

Seconded.

> looks acceptable to me, although I don't necessarily agree with all of
> it :)

[..snip..]

-- 
mailto:address@hidden